[PATCH] xorg-wrapper: fix build without libdrm
samuel.thibault at ens-lyon.org
Mon Oct 19 02:04:43 PDT 2015
Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit :
> On 19-10-15 10:53, Samuel Thibault wrote:
> >Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit :
> >>>@@ -237,6 +242,7 @@ int main(int argc, char *argv)
> >>> close(fd);
> >>> }
> >>> }
> >>This turns needs_root_rights=auto into needs_root_rights=yes do we really want that
> >>when not building with libdrm ?
> >When not building with libdrm we can't detect if it needs root rights.
> Right, but I'm not sure that means that just running as root then is the right
> thing. I agree it will ensure that everything just works, but from a security
> pov it just feels wrong.
Well, when building without libdrm (and thus without kms), execution
without root will just not work at all.
More information about the xorg-devel