[PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede hdegoede at redhat.com
Mon Oct 19 01:56:26 PDT 2015


On 19-10-15 10:53, Samuel Thibault wrote:
> Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit :
>>> @@ -237,6 +242,7 @@ int main(int argc, char *argv[])
>>>               close(fd);
>>>           }
>>>       }
>>> +#endif
>> This turns needs_root_rights=auto into needs_root_rights=yes do we really want that
>> when not building with libdrm ?
> When not building with libdrm we can't detect if it needs root rights.

Right, but I'm not sure that means that just running as root then is the right
thing. I agree it will ensure that everything just works, but from a security
pov it just feels wrong.

In which case would you want to build without libdrm anyways ? Can you
explain the use-case for this patch ?



More information about the xorg-devel mailing list