[PATCH v2 1/4] randr: Silence -Wshift-negative-value warnings

Jeremy Huddleston Sequoia jeremyhu at apple.com
Sun Oct 18 23:12:49 PDT 2015


rrtransform.c:199:23: warning: shifting a negative signed value is undefined [-Wshift-negative-value,Semantic Issue]
            rot_cos = F(-1);
                      ^~~~~
rrtransform.c:114:14: note: expanded from macro 'F'
                ^~~~~~~~~~~~~~
../render/picture.h:200:24: note: expanded from macro 'IntToxFixed'
                        ^~~~~~~~~~~~~~~~~~~~~~
/opt/X11/include/pixman-1/pixman.h:130:56: note: expanded from macro 'pixman_int_to_fixed'
                                                           ~~~ ^

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
---
 randr/rrtransform.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/randr/rrtransform.c b/randr/rrtransform.c
index 26b0649..d32b43a 100644
--- a/randr/rrtransform.c
+++ b/randr/rrtransform.c
@@ -196,7 +196,7 @@ RRTransformCompute(int x,
             f_rot_sin = 0;
             f_rot_dx = width;
             f_rot_dy = height;
-            rot_cos = F(-1);
+            rot_cos = F(~0u);
             rot_sin = F(0);
             rot_dx = F(width);
             rot_dy = F(height);
@@ -207,7 +207,7 @@ RRTransformCompute(int x,
             f_rot_dx = 0;
             f_rot_dy = width;
             rot_cos = F(0);
-            rot_sin = F(-1);
+            rot_sin = F(~0u);
             rot_dx = F(0);
             rot_dy = F(width);
             break;
@@ -230,7 +230,7 @@ RRTransformCompute(int x,
         scale_dy = 0;
         if (rotation & RR_Reflect_X) {
             f_scale_x = -1;
-            scale_x = F(-1);
+            scale_x = F(~0u);
             if (rotation & (RR_Rotate_0 | RR_Rotate_180)) {
                 f_scale_dx = width;
                 scale_dx = F(width);
@@ -242,7 +242,7 @@ RRTransformCompute(int x,
         }
         if (rotation & RR_Reflect_Y) {
             f_scale_y = -1;
-            scale_y = F(-1);
+            scale_y = F(~0u);
             if (rotation & (RR_Rotate_0 | RR_Rotate_180)) {
                 f_scale_dy = height;
                 scale_dy = F(height);
-- 
2.6.1



More information about the xorg-devel mailing list