[PATCH xquartz 09/10] xdmcp: Declare XdmcpFatal _X_NORETURN

Alan Coopersmith alan.coopersmith at oracle.com
Wed Oct 14 15:39:03 PDT 2015


On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote:
> xdmcp.c:1404:1: warning: function 'XdmcpFatal' could be declared with attribute 'noreturn'
> [-Wmissing-noreturn,Semantic Issue]
>
> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
> ---
>   os/xdmcp.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/os/xdmcp.c b/os/xdmcp.c
> index 7939b41..5bdcbe9 100644
> --- a/os/xdmcp.c
> +++ b/os/xdmcp.c
> @@ -1399,6 +1399,7 @@ recv_alive_msg(unsigned length)
>       }
>   }
>
> +_X_NORETURN
>   static void
>   XdmcpFatal(const char *type, ARRAY8Ptr status)
>   {
>

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list