[PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

[Alan Coopersmith]

On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote:
> xdmauth.c:230:13: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of
> type
> 'int'
>        which may cause truncation of value [-Wabsolute-value,Semantic Issue]
>          if (abs(now - client->time) > TwentyFiveMinutes) {
>              ^
> xdmauth.c:230:13: note: use function 'labs' instead [Semantic Issue]
>          if (abs(now - client->time) > TwentyFiveMinutes) {
>              ^~~
>              labs
> xdmauth.c:302:9: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type
> 'int' which
>        may cause truncation of value [-Wabsolute-value,Semantic Issue]
>      if (abs(client->time - now) > TwentyMinutes) {
>          ^
> xdmauth.c:302:9: note: use function 'labs' instead [Semantic Issue]
>      if (abs(client->time - now) > TwentyMinutes) {
>          ^~~
>          labs
>
> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
> ---
>   os/xdmauth.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/os/xdmauth.c b/os/xdmauth.c
> index f11cbb9..482bc67 100644
> --- a/os/xdmauth.c
> +++ b/os/xdmauth.c
> @@ -227,7 +227,7 @@ XdmClientAuthTimeout(long now)
>       prev = 0;
>       for (client = xdmClients; client; client = next) {
>           next = client->next;
> -        if (abs(now - client->time) > TwentyFiveMinutes) {
> +        if (labs(now - client->time) > TwentyFiveMinutes) {
>               if (prev)
>                   prev->next = next;
>               else
> @@ -299,7 +299,7 @@ XdmAuthorizationValidate(unsigned char *plain, int length,
>       }
>       now += clockOffset;
>       XdmClientAuthTimeout(now);
> -    if (abs(client->time - now) > TwentyMinutes) {
> +    if (labs(client->time - now) > TwentyMinutes) {
>           free(client);
>           if (reason)
>               *reason = "Excessive XDM-AUTHORIZATION-1 time offset";
>

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc