[PATCH] xf86-video-dummy: fix pointer limits when resizing

Antoine Martin antoine at nagafix.co.uk
Tue Oct 13 22:50:56 PDT 2015


Hi,

Pointer events are clipped to the original screen dimensions with the
dummy driver when using RandRto switch to a higher resolution at runtime.

I don't know if this is the correct fix for it (is there a more generic
solution?), but this has been used extensively over the last year
without any noticeable side effects:

--- xf86-video-dummy-0.3.6/src/dummy_driver.c    2014-11-05
19:24:02.668656601 +0700
+++ xf86-video-dummy-0.3.6.new/src/dummy_driver.c    2014-11-05
19:37:53.076061853 +0700
@@ -55,6 +55,9 @@
 #include <X11/extensions/xf86dgaproto.h>
 #endif
 
+/* Needed for fixing pointer limits on resize */
+#include "inputstr.h"
+
 /* Mandatory functions */
 static const OptionInfoRec *    DUMMYAvailableOptions(int chipid, int
busid);
 static void     DUMMYIdentify(int flags);
@@ -713,6 +716,26 @@
         RRTellChanged(pScrn->pScreen);
     }
 #endif
+    //ensure the screen dimensions are also updated:
+    pScrn->pScreen->width = mode->HDisplay;
+    pScrn->pScreen->height = mode->VDisplay;
+    pScrn->virtualX = mode->HDisplay;
+    pScrn->virtualY = mode->VDisplay;
+    pScrn->frameX1 = mode->HDisplay;
+    pScrn->frameY1 = mode->VDisplay;
+
+    //ensure the pointer uses the new limits too:
+    DeviceIntPtr pDev;
+    SpritePtr pSprite;
+    for (pDev = inputInfo.devices; pDev; pDev = pDev->next) {
+        if (pDev->spriteInfo!=NULL && pDev->spriteInfo->sprite!=NULL) {
+            pSprite = pDev->spriteInfo->sprite;
+            pSprite->hotLimits.x2 = mode->HDisplay;
+            pSprite->hotLimits.y2 = mode->VDisplay;
+            pSprite->physLimits.x2 = mode->HDisplay;
+            pSprite->physLimits.y2 = mode->VDisplay;
+        }
+    }
     return TRUE;
 }
 

Cheers
Antoine



More information about the xorg-devel mailing list