[PATCH xwayland 1/2] xwayland: Update actual screen and root window size on output hot plug

Adam Jackson ajax at nwnk.net
Wed Oct 7 07:42:20 PDT 2015

On Wed, 2015-10-07 at 21:57 +0800, Jonas Ã…dahl wrote:
> On Wed, Oct 07, 2015 at 12:09:17PM +0100, Daniel Stone wrote:
> > Thanks, looks good to me. I had a half-complete version of the same,
> > but just forgot to update the root-clip, hence why it didn't work.
> It is thanks to Olivier that the SetRootClip calls is there. It was quite
> hard to spot that it was necessary.
> > One
> > thing I did notice from the earlier iteration though, is that for me,
> > I was seeing this being called when xwl_screen->screen is NULL, thus a
> > segfault on startup. Are you not seeing the same?
> I got a segfault if I didn't NULL check the root window of the screen,
> because the root window is initialized later than the outputs are in
> dix_main().
> But since we get the Wayland registry and discover the outputs after we
> set xwl_screen->screen ScreenPtr in xwl_screen_init(), we can be sure its
> always non-NULL.

remote: I: patch #61202 updated using rev 216bdbc7351e2078d94857a3323f6cd8f0d2f191.
remote: I: patch #61203 updated using rev 880d4e78b1823bcc0e66e68270af1a475f097bb5.
remote: I: 2 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   211d4c2..880d4e7  master -> master

- ajax

More information about the xorg-devel mailing list