[PATCH v6 RFC 09/10] config/udev: better distinguish between real keyboards and other key input devices

Adam Jackson ajax at nwnk.net
Thu Oct 1 07:40:15 PDT 2015


On Thu, 2015-09-03 at 15:00 -0300, LaƩrcio de Sousa wrote:

> -#define ATTR_KEYBOARD (1<<0)
> -#define ATTR_POINTER (1<<1)
> -#define ATTR_JOYSTICK (1<<2)
> -#define ATTR_TABLET (1<<3)
> -#define ATTR_TOUCHPAD (1<<4)
> -#define ATTR_TOUCHSCREEN (1<<5)
> +#define ATTR_KEY (1<<0)
> +#define ATTR_KEYBOARD (1<<1)
> +#define ATTR_POINTER (1<<2)
> +#define ATTR_JOYSTICK (1<<3)
> +#define ATTR_TABLET (1<<4)
> +#define ATTR_TOUCHPAD (1<<5)
> +#define ATTR_TOUCHSCREEN (1<<6)

This is an ABI break, these flags are visible to input drivers.  Just
leave the old defines in place and make ATTR_KEY be (1<<6) even though
it's not as pretty.  I think if you do that you can drop the xf86Xinput
change too.

- ajax


More information about the xorg-devel mailing list