[PATCH xserver 08/20] hw/kdrive: Use NotifyFd interface for kdrive/linux APM monitoring

Keith Packard keithp at keithp.com
Mon Nov 23 17:49:20 PST 2015


Adam Jackson <ajax at nwnk.net> writes:

> This tripped me up at first (here and elsewhere in the series), it
> looks weird to read an fd that isn't the one passed in as an argument. 

I fixed this one and the kdrive/linux APM one. The other patches either
already used the passed-in fd directly, or had some more complicated
structure involving additional layers of closures and callbacks.

Ignoring the efficiency issue, it seems clearer to handle data from the
active file descriptor instead of fetching the same value from some
random global.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151123/1cfb6edc/attachment.sig>


More information about the xorg-devel mailing list