[PATCH] xwayland: Do set root clip with rootless

Olivier Fourdan ofourdan at redhat.com
Sat Nov 21 05:39:13 PST 2015


Hi Adam,

----- Original Message -----
> On Fri, 2015-11-20 at 18:41 +0100, Olivier Fourdan wrote:
> [...]
> > @@ -184,7 +181,6 @@ update_screen_size(struct xwl_output *xwl_output, int
> > width, int height)
> >      if (xwl_screen->screen->root) {
> >          xwl_screen->screen->root->drawable.width = width;
> >          xwl_screen->screen->root->drawable.height = height;
> > -        SetRootClip(xwl_screen->screen, TRUE);
> >          RRScreenSizeNotify(xwl_screen->screen);
> >      }
> >  
> 
> Same deal here, re-enabling the root clip is what revalidates the
> window tree and generates exposures. The SetRootClip should be
> conditional as above. The outer conditional can be removed since it's
> always true (and we do want to update root window geometry even when
> rootless).

We still need to check if xwl_screen->screen->root is non-null otherwise that code segfault at startup, so I would just move the SRC(TRUE) outside of the test within its own test "if (!xwl_screen->rootless)".

Will post the updated patch in a minute.

Cheers,
Olivier


More information about the xorg-devel mailing list