[PATCH v2 2/4] Free the data returned by XGetWindowProperty()

walter harms wharms at bfs.de
Thu May 21 10:13:56 PDT 2015


maybe this was the case in older versions.
a current free() should accept NULL.

Xfree is onyl a wrapper for free()
#define Xfree(ptr) free((ptr))


Am 21.05.2015 19:02, schrieb Jasper St. Pierre:
> I thought I remembered something which tried to poke the pointer first
> to make it crash if it was NULL, since freeing of a NULL pointer was
> considered a bug.
> 
> On Thu, May 21, 2015 at 9:34 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 21 May 2015 at 17:21, Jasper St. Pierre <jstpierre at mecheye.net> wrote:
>>> XFree crashes when passed NULL.
>>>
>> I've never tried it personally, but it seems that XFree() is a simple
>> wrapper around free(), which should work just fine. [1] [2]
>> On the other hand $ man 3 XFree clearly states that "NULL pointer
>> cannot be passed to this function" :-\


the documentation need a fix.


>> -Emil
>>
>> [1] http://cgit.freedesktop.org/xorg/lib/libX11/tree/src/XlibInt.c#n1546
>> [2] http://cgit.freedesktop.org/xorg/lib/libX11/tree/include/X11/Xlibint.h#n332
> 
> 
> 


More information about the xorg-devel mailing list