[PATCH 1/2] xserver: add xorg.conf support for gpu devices.

Mark Kettenis mark.kettenis at xs4all.nl
Tue Mar 31 14:16:06 PDT 2015


> From: Dave Airlie <airlied at gmail.com>
> Date: Tue, 31 Mar 2015 17:12:28 +1000
> 
> This should allow for easier tweaking of driver options which
> currently mess up the GPU device discovery process.

Sorry, not a real review, but:

> diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
> index d42572f..8992208 100644
> --- a/hw/xfree86/common/xf86Config.c
> +++ b/hw/xfree86/common/xf86Config.c
> @@ -411,8 +411,10 @@ xf86DriverlistFromConfig(void)
>       */
>      if (xf86ConfigLayout.screens) {
>          slp = xf86ConfigLayout.screens;
> -        while ((slp++)->screen) {
> +        while ((slp)->screen) {
>              count++;
> +            count += (slp)->screen->num_gpu_devices;
> +            slp++;

The parenthesis around "slp" here are really odd.


More information about the xorg-devel mailing list