[PATCH] glamor: Perform texture2D() separately from swizzle.

[Eric Anholt]

Matt Turner <mattst88 at gmail.com> writes:

> The texture2D() happens in each branch, so we may as well do it as early
> as possible and hide some of its latency in the branching instructions.
> Moving it outside the (uniform) control flow reduces the number of
> instructions in the fs_source shader from 64 to 46 and in the
> set_alpha_source shader from 69 to 47 on Haswell.
> ---
> Untested. Given a short primer on benchmarking glamor I'd be happy
> to run some benchmarks.

I wouldn't worry about the benchmarking on this one -- it seems
obviously better, and we're pretty skeptical of this code's existence.
But since it's there and this is an improvement, I've reviewed and
applied it to -next.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150324/49b8dc25/attachment.sig>