[PATCH v3] configurable maximum number of clients

Olivier Fourdan ofourdan at redhat.com
Mon Jun 15 06:28:06 PDT 2015


Hi all,

Could someone be so kind and take some time to do a review of this patch?

I know it's quite intrusive but tbh such a feature requires to touch the core of the X server.

It seems to work fine here (see my other email [1] with the test programs used to verify).

Thanks in advance,
Olivier

[1] http://lists.x.org/archives/xorg-devel/2015-June/046584.html

----- Original Message -----
> Make the maximum number of clients user configurable, either from the command
> line or from xorg.conf
> 
> This patch works by using the MAXCLIENTS (raised to 512) as the maximum
> allowed number of clients, but allowing the actual limit to be set by the
> user to a lower value (keeping the default of 256).
> 
> There is a limit size of 29 bits to be used to store both the client ID and
> the X resources ID, so by reducing the number of clients allowed to connect
> to
> the X server, the user can increase the number of X resources per client or
> vice-versa.
> 
> Parts of this patch are based on a similar patch from Adam Jackson
> <ajax at redhat.com>
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
> ---
>  v2: Use the user set client limit in multiple places instead of MAXCLIENTS,
>      Bump value for MAXCLIENTS, MAXSELECT, MAXSOCKS and OPEN_MAX to 512,
>      Requires an updated Xproto.
>  v3: Fix 256 limit still remaining in InitConnectionLimits()


More information about the xorg-devel mailing list