[PATCH 1/4] modesetting: Implement 32->24 bpp conversion in shadow update

[Eric Anholt]

Matt Turner <mattst88 at gmail.com> writes:

> On Wed, Jul 22, 2015 at 9:14 AM, Adam Jackson <ajax at redhat.com> wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> 24bpp front buffers tend to be the least well tested path for client
>> rendering.  On the qemu cirrus emulation, and on some Matrox G200 server
>> chips, the hardware can't do 32bpp at all.  It's better to just allocate
>> a 32bpp shadow and downconvert in the upload hook than expose a funky
>> pixmap format to clients.
>>
>> [ajax: Ported from RHEL and separate modesetting driver, lifted kbpp
>> into the drmmode struct, cleaned up commit message, fixed 16bpp]
>>
>> Reviewed-by: Adam Jackson <ajax at redhat.com>
>> Signed-off-by: Dave Airlied <airlied at redhat.com>
>> ---
>>  hw/xfree86/drivers/modesetting/Makefile.am       |   2 +
>>  hw/xfree86/drivers/modesetting/driver.c          |  41 ++++---
>>  hw/xfree86/drivers/modesetting/drmmode_display.c |  24 ++--
>>  hw/xfree86/drivers/modesetting/drmmode_display.h |   2 +
>>  hw/xfree86/drivers/modesetting/sh3224.c          | 140 +++++++++++++++++++++++
>>  hw/xfree86/drivers/modesetting/sh3224.h          |   7 ++
>>  6 files changed, 193 insertions(+), 23 deletions(-)
>>  create mode 100644 hw/xfree86/drivers/modesetting/sh3224.c
>>  create mode 100644 hw/xfree86/drivers/modesetting/sh3224.h
>>
>> diff --git a/hw/xfree86/drivers/modesetting/sh3224.c b/hw/xfree86/drivers/modesetting/sh3224.c
>> new file mode 100644
>> index 0000000..a64a103
>> --- /dev/null
>> +++ b/hw/xfree86/drivers/modesetting/sh3224.c
>> @@ -0,0 +1,140 @@
>> +/*
>> + *
>> + * Copyright © 2000 Keith Packard
>
> Whoops. (Keith appears throughout below as well).

It's clearly derived from fb/fb24_32.c.  But I'm not sure where things
would have switched from SuSE to keithp.

It does make me wonder why we don't just use fb's CopyArea to do the
job, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150727/858c5f44/attachment.sig>