[PATCH:xfs 1/2] FD_SETSIZE fixes.

[Thomas Klausner]

On Wed, Jul 22, 2015 at 03:08:33PM +0100, Emil Velikov wrote:
> On 21 July 2015 at 22:18, Thomas Klausner <wiz at netbsd.org> wrote:
> > Hi Emil!
> >
> > On Mon, Jul 20, 2015 at 05:00:43PM +0100, Emil Velikov wrote:
> >> On 19 July 2015 at 08:56, Thomas Klausner <wiz at netbsd.org> wrote:
> >> > From: Matthew Green <mrg at NetBSD.org>
> >> >
> >> > Move X11/Xpoll.h include earlier than sys/select.h to avoid missing
> >> > out on setting FD_SETSIZE early enough.
> >> >
> >> Shouldn't there be a comment to prevent the next person from
> >> reverting/messing up with the order ?
> >>
> >> ...
> >> > diff --git a/os/io.c b/os/io.c
> >> > index 124ecd8..8ebb8e4 100644
> >> > --- a/os/io.c
> >> > +++ b/os/io.c
> >> > @@ -46,6 +46,8 @@ in this Software without prior written authorization from The Open Group.
> >> >   * THIS SOFTWARE.
> >> >   */
> >> >
> >> > +#include       "X11/Xpoll.h"
> >> > +
> >> >  #include       "config.h"
> >> >
> >> This looks like a no-go. I cannot think of a case where you'd want
> >> anything before config.h.
> >
> > So would you like the attached patch pushed too?
> >
> Yes that's perfect. Can you please add the comment in os/connection.c
> as well please.
> 
> With that the patch is Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks. I've added such comments and pushed the patches.


I'm still looking for a reviewer of the corresponding patch in Xpoll.h
itself (xproto). Perhaps patches 2&3 in the series discouraged
reviewers, but patch 1 is needed for this, otherwise the other
re-ordering patches are not sufficient.

Cheers,
 Thomas