[PATCH:xf86-video-geode] Properly hide config.h inclusion inside HAVE_CONFIG_H.

Emil Velikov emil.l.velikov at gmail.com
Wed Jul 22 07:05:28 PDT 2015


On 21 July 2015 at 22:12, Thomas Klausner <wiz at netbsd.org> wrote:
> On Mon, Jul 20, 2015 at 05:03:13PM +0100, Emil Velikov wrote:
>> Hi Thomas,
>>
>> On 20 July 2015 at 09:37, Thomas Klausner <wiz at netbsd.org> wrote:
>> > From: Matthew Green <mrg at NetBSD.org>
>> >
>> > Signed-off-by: Thomas Klausner <wiz at NetBSD.org>
>> > ---
>> >  src/geode.h | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/src/geode.h b/src/geode.h
>> > index ac69368..244cadf 100644
>> > --- a/src/geode.h
>> > +++ b/src/geode.h
>> > @@ -28,7 +28,9 @@
>> >  #define _GEODE_H_
>> >
>> >  #include "geode_pcirename.h"
>> > +#ifdef HAVE_CONFIG_H
>> >  #include "config.h"
>> > +#endif
>> >
>> While you're here, can you move the config.h inclusion before the
>> geode_pcirename.h one ?
>
> Sure, attached.
Personally, I'd mention something like "v2: make config.h inclusion
the first one". But either way

Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks
Emil


More information about the xorg-devel mailing list