[PATCH libX11] Add missing NULL checks to ICWrap

Alan Coopersmith alan.coopersmith at oracle.com
Sun Jul 19 08:50:53 PDT 2015


On 05/18/15 06:49 AM, Ross Burton wrote:
> ICWrap.c dereferences the xim parameter passed in from client code without a
> NULL check.  I have seen mplayer trigger this resulting in a segfault.  In this
> case mplayer had called XOpenIM and NULL was returned which was later passed
> into XCreateIC.
>
> Patch originally by Drew Moseley <drew_moseley at mentor.com>.
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>   src/xlibi18n/ICWrap.c | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)

Thanks - makes sense and looks good to me, so pushed to git master:

To ssh://git.freedesktop.org/git/xorg/lib/libX11
    26e0d2d..c827edc  master -> master

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list