[PATCH 02/12] glamor: Ignore picture formats when choosing color for core rendering.

Dave Airlie airlied at gmail.com
Wed Jul 8 21:19:12 PDT 2015


On 9 July 2015 at 05:45, Eric Anholt <eric at anholt.net> wrote:
> Attaching a picture to a pixmap doesn't change its GL format, so it
> doesn't change how core rendering should be assigning colors to it.
>
> (Imagine XCreatePixmap(), optional XCreatePicture(pixmap) with various
> formats, XFillRectangle, XGetImage().  If the XGetImage results
> changed, this would be wrong).
>
> Fixes all failures in "rendercheck -t fill" and, as a result, the
> remaining failures in "rendercheck -t blend -o src -f
> a8r8g8b8,x2r10g10b10"
>
> Signed-off-by: Eric Anholt <eric at anholt.net>

Reviewed-by: Dave Airlie <airlied at redhat.com>


More information about the xorg-devel mailing list