glamor: rendercheck fixes and picture handling simplification

Eric Anholt eric at anholt.net
Wed Jul 8 21:35:31 PDT 2015


Michel Dänzer <michel at daenzer.net> writes:

> On 09.07.2015 04:45, Eric Anholt wrote:
>> This series came out of the process of trying to figure out if I could
>> safely store a8 pixmaps in an a8r8g8b8 FBO, to improve glamor
>> performance on VC4 (which doesn't support 8-bit FBOs).  It turns out
>> the answer is "not quite", but the Render code had a lot of bugs
>> obscuring that fact.
>
> Patches 1, 3-5, 8, 10-12 are
>
> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>
>
> Patch 2: Should the shortlog say "choosing format" instead of "choosing
> color"? Either way,

Color was referring to the one caller, so I think it's good.

> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>
>
> Patch 9: Maybe add an XXX comment that we're overshooting for
> transforms? Either way,

Done.  Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150708/b730b8db/attachment.sig>


More information about the xorg-devel mailing list