[PATCH] glamor_egl: Properly free resources on init-error and exit

Eric Anholt eric at anholt.net
Wed Jul 8 10:49:59 PDT 2015


Hans de Goede <hdegoede at redhat.com> writes:

> glamor_egl_init() was not undoing any of the init steps on init error,
> add an glamor_egl_cleanup() function and use this both on error and on exit
> to cleanup the various resources.
>
> Even on a clean exit eglTerminate() was not being called, causing the fd
> dup()-ed by eglInitialize() to stay open, call eglTerminate() from the new
> glamor_egl_cleanup() to fix this.
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Reviewed-by: Eric Anholt <eric at anholt.net>

I'll stick it in my next pull request, unless keithp grabs it first.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150708/190c1527/attachment.sig>


More information about the xorg-devel mailing list