[PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

Keith Packard keithp at keithp.com
Wed Jul 8 10:38:31 PDT 2015


Eric Anholt <eric at anholt.net> writes:

> Now that it's always non-null when the pixmap is non-null, we don't
> need so much of this.  glamor_get_pixmap_private() itself still
> accepts a NULL pixmap and returns NULL, because of glamor_render.c

Might want to change glamor_pixmap_type to explicitly make GLAMOR_MEMORY
be zero just to make it clear that fbCreatePixmap returns a valid glamor
pixmap?

Otherwise, this all looks correct to me.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150708/8f1db9aa/attachment-0001.sig>


More information about the xorg-devel mailing list