[PATCH v2] glamor: only use (un)pack_subimage when available

Maarten Lankhorst maarten.lankhorst at canonical.com
Tue Jan 27 03:43:58 PST 2015


Op 27-01-15 om 11:06 schreef Maarten Lankhorst:
> Check for GL_EXT_unpack_subimage and GL_NV_pack_subimage to
> check if GL_(UN)PACK_ROW_LENGTH is available. Set the offsets
> manually to prevent calls to GL_(UN)PACK_SKIP_*.
>
> Check support for GL_NV_pack_subimage as suggested by Matt Turner.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at ubuntu.com>
>
> Changes since v1:
> glamor_upload_boxes may be called with bits = NULL by glamor_fini_pixmap,
> add a check for it.
>
Never mind, the 'fix' isn't. glReadPixels treats it as offset correctly, so v1 should be correct with bits = NULL.


More information about the xorg-devel mailing list