[PATCH:libXxf86vm] Tell the compiler it's unlikely we're talking to an XFree86 3.x server

Alan Coopersmith alan.coopersmith at oracle.com
Fri Jan 23 13:06:45 PST 2015


On 01/23/15 10:32 AM, Keith Packard wrote:
> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
>
>> Hint that the current (XFree86 4.0 & later) version of the protocol
>> is most common today.
>
> I thought _X_UNLIKELY was to direct optimization? If so, it's hard to
> see why we'd worry about that in this extension, unless you think
> there's some documentation value here?

Right - if I hadn't been fixing this code already, I probably wouldn't
have bothered, and the reality is it will mostly be useful as a hint
to future developers, but it should help the compilers branch prediction
and code path analysis a little.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list