[PATCH 7/7] XXX glamor: Only use supported tex formats

[Maarten Lankhorst]

Hey,

Op 13-01-15 om 03:49 schreef Eric Anholt:
> Maarten Lankhorst <maarten.lankhorst at ubuntu.com> writes:
>
>> Some GLES2 implementations don't support GL_UNSIGNED_8888_REV and only
>> guarantee less fancy things to work.
>>
>> I'm only certain it fixes the GLES2 errors, but is this a sane way to handle
>> things? Or am I just shutting up the errors?
> I always find the GL format arguments confusing.  If you could run XTS
> against it and it also looks good, I'd be fine with it.
It looks like this patch is wrong, but I don't see what the correct way to do to this is..

The metacity window decorator was swapping the red and blue color on the desktop
with this patch.

Using BGRA_EXT/GL_UNSIGNED_BYTE instead of RGBA works, but it gives a 502 error on glTexSubImage2d..
I also don't see the extension to support glReadPixels, it only seems to be supported for glTexImage2d and glTexSubImage2D through GL_EXT_texture_format_BGRA8888...

How would I do a component swap for the functions calling calling glTexSubImage and glReadPixels?

~Maarten