[PATCH v2 xserver] Fix a crash with XDMCP error handler

Jon TURNEY jon.turney at dronecode.org.uk
Thu Jan 22 03:45:58 PST 2015


On 22/01/2015 09:17, Olivier Fourdan wrote:
> The XdmcpFatal() error handler uses a string format that the
> vpnprintf() routine does not understand, as a result any XDMCP
> fatal error leads to a server crash:
>
>      (EE) (EE) BUG: triggered 'if (f[f_idx])'
>      (EE) BUG: log.c:474 in vpnprintf()
>      (EE) Unsupported printf directive '*'
>
> Rework the XdmcpFatal() code to use a simpler string format
> instead.

I posted a similar patch [1], but it was pointed out to me that there 
are other uses of the "%*.*s" format in the X server, so I also wrote a 
patch to teach vpnprintf() how to handle that format [2].

[1] http://lists.x.org/archives/xorg-devel/2014-October/044349.html
[2] http://lists.x.org/archives/xorg-devel/2014-November/044568.html



More information about the xorg-devel mailing list