[PATCH v2 3/6] modesetting: Refactor drmmode_glamor_new_screen_pixmap

Keith Packard keithp at keithp.com
Thu Jan 8 14:11:35 PST 2015


Jason Ekstrand <jason at jlekstrand.net> writes:

> The original drmmode_glamor_new_screen_pixmap function was specific to the
> primary screen pixmap.  This commit pulls the guts out into a new, more
> general, drmmode_set_pixmap_bo function for setting a buffer on a pixmap.
> The new function also properly tears down the glamor bits if the buffer
> being set is NULL.  The drmmode_glamor_new_screen_pixmap function is now
> just a 3-line wrapper around drmmode_set_pixmap_bo.
>
> v2 Jason Ekstrand <jason.ekstrand at intel.com>:
>  - Re-arranged code in drmmode_set_pixmap_bo and
>    drmmode_glamor_handle_new_screen_pixmap so that glamor_set_screen_pixmap
>    only gets called for the screen pixmap
>  - Guard the call to glamor_set_screen_pixmapa with a drmmode->glamor
>  check

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150108/fd7bcc18/attachment.sig>


More information about the xorg-devel mailing list