[PATCH v2 2/6] modesetting: Use a gbm buffer for shadow if we are using glamor

[Keith Packard]

Jason Ekstrand <jason at jlekstrand.net> writes:

> +    old_shadow = drmmode->shadow_bo;
>  
>      if (!drmmode_create_bo(drmmode, &drmmode->front_bo,
>                             width, height, scrn->bitsPerPixel))
> @@ -1218,13 +1219,9 @@ drmmode_xf86crtc_resize(ScrnInfoPtr scrn, int width, int height)
>      }
>  
>      if (drmmode->shadow_enable) {
> -        uint32_t size = scrn->displayWidth * scrn->virtualY *
> -            ((scrn->bitsPerPixel + 7) >> 3);
> -        new_pixels = calloc(1, size);
> -        if (new_pixels == NULL)
> +        if (!drmmode_create_bo(drmmode, &drmmode->shadow_bo,
> +                               width, height, scrn->bitsPerPixel))
>              goto fail;
> -        free(drmmode->shadow_fb);
> -        drmmode->shadow_fb = new_pixels;
>      }

I don't see the old shadow_bo getting freed anywhere; did I miss
something?

The rest of this patch looks good and is

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150108/65c6c3c3/attachment.sig>