[PATCH:libXt] Use string.h instead of X11/Xos.h.

Alan Coopersmith alan.coopersmith at oracle.com
Thu Jan 8 10:03:07 PST 2015


Long long ago, Xos.h was needed to choose between <string.h> & <strings.h>
depending on the OS in use.

Today we can rely on C89 & later providing <string.h> everywhere for us, so:

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

	-alan-

On 01/ 8/15 12:34 AM, Thomas Klausner wrote:
> We have this patch in NetBSD because makestrs is now a build tool and
> we want to avoid having to pull in X headers if they are not needed,
> easier to port.
>
> Cheers,
>   Thomas
>
> On Thu, Jan 08, 2015 at 09:19:02AM +0100, Thomas Klausner wrote:
>> Only symbols from the former are needed.
>>
>> Signed-off-by: Thomas Klausner <wiz at NetBSD.org>
>> ---
>>   util/makestrs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/util/makestrs.c b/util/makestrs.c
>> index a52866a..ce0a0a3 100644
>> --- a/util/makestrs.c
>> +++ b/util/makestrs.c
>> @@ -27,7 +27,7 @@ in this Software without prior written authorization from The Open Group.
>>   /* Constructs string definitions */
>>
>>   #include <stdio.h>
>> -#include <X11/Xos.h>
>> +#include <string.h>
>>   #include <stdlib.h>
>>   #include <unistd.h>
>>
>> --
>> 2.2.1
>>
>> _______________________________________________
>> xorg-devel at lists.x.org: X.Org development
>> Archives: http://lists.x.org/archives/xorg-devel
>> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>


-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list