[PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

[Eric Anholt]

Keith Packard <keithp at keithp.com> writes:

> Kenneth Graunke <kenneth at whitecape.org> writes:
>
>> That's true.  I should probably just resurrect your Xephyr VAO patch, and
>> extend it for the rest of Glamor as well.
>
> Yeah, would be good as that's required for 3.0 core context
> support. Note that most of the VAO work is actually in the Render
> extension drawing code, and I plan on reworking all of that in the
> coming months. I've already done render glyph support, which has some
> of infrastructure stuff already completed.
>
>> Can we require VAO support?  The GL_ARB_vertex_array_object extension has
>> been supported everywhere for years.  It looks like there's an ES2 extension
>> extension as well: GL_OES_vertex_array_object.  Both Mesa and PVR appear to
>> support it; I wasn't able to find information about other drivers.
>
> I doubt we can require it, but we could obviously have dire fallbacks
> when it's missing.

I don't really see a reason to not require it -- the drivers anyone's
currently using glamor on have it, and I think if someone runs into an
important driver that doesn't, the fallback could be structured as
pretty much a little replacement for the Bind call that does a for loop
over attributes doing re-binds of the saved state.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150105/58748b1c/attachment.sig>