[PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

Kenneth Graunke kenneth at whitecape.org
Sun Jan 4 17:18:57 PST 2015


On Sunday, January 04, 2015 04:47:49 PM Keith Packard wrote:
> Eric Anholt <eric at anholt.net> writes:
> 
> > I think this will break glamor_xv.c and Xephyr, but I'm definitely in
> > favor of just making those explicitly bind their VBO state instead (or
> > maybe just use the same VBO if we can).
> 
> I think we're going to rework a bunch of this code when we switch to
> vertex arrays anyways? In any case, it sounds like we need to cache
> which VBO is bound and avoid calling into GL when we don't need to.

That's true.  I should probably just resurrect your Xephyr VAO patch, and
extend it for the rest of Glamor as well.

Can we require VAO support?  The GL_ARB_vertex_array_object extension has
been supported everywhere for years.  It looks like there's an ES2 extension
extension as well: GL_OES_vertex_array_object.  Both Mesa and PVR appear to
support it; I wasn't able to find information about other drivers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150104/13be2687/attachment-0001.sig>


More information about the xorg-devel mailing list