Limit DRI2Drawable reference leak

Chris Wilson chris at chris-wilson.co.uk
Sun Feb 22 01:24:58 PST 2015


On Sun, Feb 22, 2015 at 09:02:41AM +0000, Chris Wilson wrote:
> Yes, that is what I think the mesa patch is about. I think the solution
> would have been that the DRI2Drawable take a refcnt on its parent and
> then DRI2DestroyDrawable could be made to work. However, if we did that
> today we would end up with a massive Drawable leak - and pushing the
> change to mesa would also then expose us to the GLXDrawable vs Drawable
> close race (and BadDrawable errors again). This also sinks using named
> references - unless only named references also reference their parent.

Except Windows don't have reference counts.
 
> I think this is something we cannot fix, but we can at least apply
> damage limitation.

Doubly so now.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the xorg-devel mailing list