[PATCH] os/access: fix regression in server interpreted auth

Dave Airlie airlied at gmail.com
Mon Feb 16 20:40:27 PST 2015


From: Dave Airlie <airlied at redhat.com>

This was reported on irc on Fedora when rawhide went to 1.17.1.

regression occured in: 2566835b4374edb3e5a8353d4f7c9e7ec4851c57
 os: Eliminate uninitialized value warnings from access.c

siAddrMatch doesn't need addr to be a useful value, it checks
some things like localuser without having an address at all.

Signed-off-by: Dave Airlie <airlied at redhat.com>
---
 os/access.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/os/access.c b/os/access.c
index 28f2d32..8fa028e 100644
--- a/os/access.c
+++ b/os/access.c
@@ -1392,7 +1392,7 @@ InvalidHost(register struct sockaddr *saddr, int len, ClientPtr client)
     }
     for (host = validhosts; host; host = host->next) {
         if (host->family == FamilyServerInterpreted) {
-            if (addr && siAddrMatch(family, addr, len, host, client)) {
+            if (siAddrMatch(family, addr, len, host, client)) {
                 return 0;
             }
         }
-- 
1.9.3



More information about the xorg-devel mailing list