[PATCH libpciaccess 5/5] linux: Remove no longer needed _GNU_SOURCE define.

Emil Velikov emil.l.velikov at gmail.com
Sat Feb 14 09:06:02 PST 2015

On 12/02/15 22:14, Alan Coopersmith wrote:
> On 02/10/15 06:55 AM, Emil Velikov wrote:
>> With earlier commit we're including config.h before the system headers.
>> As such we no longer require the extra define as it is handled/set via
>> AC_USE_SYSTEM_EXTENSIONS. Note platforms which do not use autotools but
>> require the define (such as Android) might need to set it explicitly.
>> Suggested-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> I didn't realize anyone was building libpciaccess without using autotools.
> If this helps them, leaving one extra #define in the source doesn't hurt
> us,
> so I don't mind skipping this little cleanup.
To build for Android one requires additional patch, adding their
makefile - Android.mk. The latter already sets a handful of defines
manually. With that said - fixing their build should be dead trivial,
but I don't have a strong opinion either way :-)


More information about the xorg-devel mailing list