[PATCH] Massage cpp output before passing to awk for generating sdksyms.c

Alan Coopersmith alan.coopersmith at oracle.com
Fri Feb 13 18:38:21 PST 2015


On 02/13/15 12:37 AM, Hans de Goede wrote:
> Hi,
>
> On 11-02-15 17:04, Alan Coopersmith wrote:
>> Fixes build errors when using Solaris Studio 12.4 from getting the wrong
>> strings (such as __attribute__) put into the sdksyms function list.
>>
>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>
> Hmm, have you seen my patch to sdksyms.sh to fix buildign with gcc5's
> cpp ? It is not a very good patch, but at least it sticks to awk only,
> I do not think adding sed to the mix makes things better.

I tried fixing this just in the awk, and it turned into a hairball that
still didn't work.

> What we really need is someone who knows awk to step in and help us
> with both our problems and fix things properly.
>
> So does anyone know anyone who may be able to help out with fixing
> the awk stuff ?

Do we need to stick to awk?  Maybe python or perl would be better?

Or do we still need sdksyms at all?   I don't actually remember the
details of why it even exists - did some compilers/linkers optimize
out these functions even though they are marked as exported?

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list