[PATCH 1/3] glamor: Just set the logic op to what we want at the start of all rendering.

Keith Packard keithp at keithp.com
Thu Feb 5 10:35:00 PST 2015

Eric Anholt <eric at anholt.net> writes:

> If logic op is enabled, blending doesn't happen.

Sure, but presumably we're almost always leaving the logic op disabled
as we're using either Render or GXcopy. *not* calling glDisable for
every operation seems like it might be a good idea.

> Yeah, I was a bit bothered by doing this, because it means if we ever
> get logic ops in gles2, this check would need to be updated.  But so
> far, ephyr isn't using glamor_priv.h.  I feel an in-tree use of glamor
> private functions is fine, though.

It would probably be better to expose that function in glamor.h than use
glamor_priv.h in ephyr.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150205/02eff812/attachment.sig>

More information about the xorg-devel mailing list