[PATCH xserver 4/8] Create a threaded mechanism for input [v3]

Keith Packard keithp at keithp.com
Thu Dec 10 11:42:36 PST 2015


Mark Kettenis <mark.kettenis at xs4all.nl> writes:

> Ugh.  Exporting global variables as part of the ABI is generally not
> such a good idea.  Perhaps it is better to use functions to acquire
> and release the input mutex instead?

Yeah, the mutex isn't exactly performance critical.

> Also, using TLS (i.e. __thread variables) isn't portable.  That
> mechanism certainly isn't supported by all platforms supported by
> Xorg.

Ok, I've added support for pthread_setspecific/pthread_getspecific and
made sure that works; I cannot test the autoconf bits (other than
verifying that if I misspell '__thread' as '__tread' it fails as
expected).

Here's just the diff from the existing patch; I'll squash this in if it
looks reasonable.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Disable-input-thread-code-with-disable-input-thread..patch
Type: text/x-diff
Size: 7765 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151210/7673f3bf/attachment.patch>
-------------- next part --------------


-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20151210/7673f3bf/attachment.sig>


More information about the xorg-devel mailing list