[PATCH xf86-video-geode] Remove UploadToScreen and DownloadFromScreen

Connor Behan connor.behan at gmail.com
Tue Aug 25 20:32:18 PDT 2015


The only reason these might be a tiny bit faster than other (recently
removed) unaccelerated hooks is that they use assembly rather than
memcpy. However, it still seems like a good idea to remove things that
make the code less portable.

Signed-off-by: Connor Behan <connor.behan at gmail.com>
---
 src/gx_accel.c | 33 ---------------------------------
 1 file changed, 33 deletions(-)

diff --git a/src/gx_accel.c b/src/gx_accel.c
index c3b3bc4..48587f2 100644
--- a/src/gx_accel.c
+++ b/src/gx_accel.c
@@ -1485,36 +1485,6 @@ amd_gx_exa_Done(PixmapPtr p)
 {
 }
 
-static Bool
-amd_gx_exa_UploadToScreen(PixmapPtr pDst, int x, int y, int w, int h,
-                          char *src, int src_pitch)
-{
-    char *dst = pDst->devPrivate.ptr;
-    int dst_pitch = exaGetPixmapPitch(pDst);
-    int bpp = pDst->drawable.bitsPerPixel;
-
-    dst += y * dst_pitch + x * (bpp >> 3);
-    GU2_WAIT_BUSY;
-    geode_memory_to_screen_blt((unsigned long) src, (unsigned long) dst,
-                               src_pitch, dst_pitch, w, h, bpp);
-    return TRUE;
-}
-
-static Bool
-amd_gx_exa_DownloadFromScreen(PixmapPtr pSrc, int x, int y, int w, int h,
-                              char *dst, int dst_pitch)
-{
-    char *src = pSrc->devPrivate.ptr;
-    int src_pitch = exaGetPixmapPitch(pSrc);
-    int bpp = pSrc->drawable.bitsPerPixel;
-
-    src += (y * src_pitch) + (x * (bpp >> 3));
-    GU2_WAIT_BUSY;
-    geode_memory_to_screen_blt((unsigned long) src, (unsigned long) dst,
-                               src_pitch, dst_pitch, w, h, bpp);
-    return TRUE;
-}
-
 /* Solid */
 
 static Bool
@@ -1944,9 +1914,6 @@ GXAccelInit(ScreenPtr pScrn)
 
         /* Sync */
         pExa->WaitMarker = amd_gx_exa_WaitMarker;
-        /* UploadToScreen */
-        pExa->UploadToScreen = amd_gx_exa_UploadToScreen;
-        pExa->DownloadFromScreen = amd_gx_exa_DownloadFromScreen;
 
         /* Solid fill */
         pExa->PrepareSolid = amd_gx_exa_PrepareSolid;
-- 
2.5.0



More information about the xorg-devel mailing list