[PATCH] glxproxy: Fix an obvious thinko in QueryExtensionsString

Keith Packard keithp at keithp.com
Wed Aug 12 09:01:29 PDT 2015


Adam Jackson <ajax at redhat.com> writes:

> gcc 5.1 throws a rather amusing warning here:
>
> glxcmdsswap.c: In function ‘__glXSwapQueryExtensionsString’:
> glxcmdsswap.c:439:1: warning: function might be candidate for attribute
> ‘noreturn’ [-Wsuggest-attribute=noreturn]
>  __glXSwapQueryExtensionsString(__GLXclientState * cl, GLbyte * pc)
>
> This is entirely accurate, albeit curiously phrased: swapping some bits
> hanging off the end of a null pointer will make Xdmx crash, so from the
> perspective of code generation the function will indeed not return.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150812/fa01395e/attachment.sig>


More information about the xorg-devel mailing list