[PATCH 2/2] xwayland: Don't (double) destroy input resources in CloseScreen

[Daniel Stone]

On 4 August 2015 at 18:17, Adam Jackson <ajax at redhat.com> wrote:
> By the time we get here we've already done CloseDownDevices, so on the
> second regeneration you get:
>
>     Invalid read of size 4
>        at 0x43402A: RemoveDevice (devices.c:1125)
>        by 0x427902: xwl_seat_destroy (xwayland-input.c:568)
>        by 0x42649C: xwl_close_screen (xwayland.c:116)
>        by 0x4B7F67: CursorCloseScreen (cursor.c:187)
>        by 0x536003: AnimCurCloseScreen (animcur.c:106)
>        by 0x539831: present_close_screen (present_screen.c:64)
>        by 0x43E486: dix_main (main.c:351)
>        by 0x30D70206FF: (below main) (libc-start.c:289)
>      Address 0x980e1a0 is 64 bytes inside a block of size 904
>
>        at 0x4A07D6A: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>        by 0x434158: RemoveDevice (devices.c:1157)
>        by 0x42F77B: CloseDeviceList (devices.c:1017)
>        by 0x430246: CloseDownDevices (devices.c:1047)
>        by 0x43E3EB: dix_main (main.c:333)
>        by 0x30D70206FF: (below main) (libc-start.c:289)
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel