[PATCH 2/3] xf86Crtc: setup tiled monitors correctly in right of

[Dave Airlie]

On 14 April 2015 at 00:35, Keith Packard <keithp at keithp.com> wrote:
> Dave Airlie <airlied at gmail.com> writes:
>
>> @@ -2121,6 +2121,7 @@ numEnabledOutputs(xf86CrtcConfigPtr config, Bool *enabled)
>>      return i;
>>  }
>>
>> +
>>  static Bool
>>  xf86TargetRightOf(ScrnInfoPtr scrn, xf86CrtcConfigPtr config,
>>                    DisplayModePtr *modes, Bool *enabled,
>
> Extra blank line
>
>> +                        config->output[ot]->initial_x = cur_x;
>> +                        config->output[ot]->initial_y = cur_y;
>
> Seems like this could just be:
>
>                            config->output[ot]->initial_x = ht * tile_info->tile_h_size;
>                            config->output[ot]->initial_y = vt * tile_info->tile_v_size;
>
> If so, this would eliminate a bit of frobbing around computing cur_x/cur_y values.

That assumes all tiles are the same size, which isn't a thing you are
guaranteed in the
spec.

Dave.