[PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

Ray Strode halfline at gmail.com
Fri Apr 17 08:01:54 PDT 2015


On Fri, Apr 17, 2015 at 10:43 AM, Hans de Goede
> You may be making life easier for casual reviewers, but you are making
> harder for the people actually merging your patches as the chances of a
> conflict increase enormously with such a large context.

Well, we all know how to deal with small conflicts pretty effortlessly I think.
And, if there are non-trivial changes to the surrounding code, then
"it applies" isn't really a good approximation for "patch is still
correct" anyway.

I agree it's a trade off, but I think more context is usually the
better way to go.

You're free to disagree, of course, and that's fine.


More information about the xorg-devel mailing list