[PATCH] xwayland-input: Remove our XYToWindow handler

Daniel Stone daniel at fooishbar.org
Mon Apr 6 09:52:43 PDT 2015


On 23 February 2015 at 15:40, Daniel Stone <daniel at fooishbar.org> wrote:
> On 21 February 2015 at 19:53, Jasper St. Pierre <jstpierre at mecheye.net> wrote:
>> This was built as a hack for simple Wayland compositors like Weston
>> which were lazy and didn't want to configure windows server-side when
>> moved.
>>
>> Since comboboxes and menus are separate toplevel O-R windows, this hack
>> breaks input as it needs to be traced normally, not simply sent to the
>> focused window.
>>
>> X11 toolkits really do need their windows to be configured correctly
>> for their O-R windows comboboxes or menus other things, so let's fix
>> the lazy compositors and remove this.
>>
>> I have tested this patch with both Weston and Mutter and neither of
>> them require any changes, and it fixes comboboxes and menus.
>>
>> If somebody then wants to revert 73698d4, that's fine by me, so we
>> reduce the amount of API that DDXen have.
>>
>> Signed-off-by: Jasper St. Pierre <jstpierre at mecheye.net>
>
> Acked-by: Daniel Stone <daniels at collabora.com>

Keith, please pick this up, with tags from Olivier and myself. If it's
any consolation, further thought has convinced me to upgrade from A-b
to R-b.

Cheers,
Danie


More information about the xorg-devel mailing list