[PATCH] Fix present_pixmap when using present_notify_msc

Keith Packard keithp at keithp.com
Tue Sep 30 16:12:31 PDT 2014


Axel Davy <axel.davy at ens.fr> writes:

> Calling present_notify_msc could cancel a pending pixmap presentation.
>
> Signed-off-by: Axel Davy <axel.davy at ens.fr>
> ---
>  present/present.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/present/present.c b/present/present.c
> index e838da7..47566c7 100644
> --- a/present/present.c
> +++ b/present/present.c
> @@ -767,7 +767,7 @@ present_pixmap(WindowPtr window,
>       * in the same frame
>       */
>  
> -    if (!update) {
> +    if (!update && pixmap) {
>          xorg_list_for_each_entry_safe(vblank, tmp, &window_priv->vblank, window_list) {
>  
>              if (!vblank->pixmap)
> -- 
> 1.9.1
>

Reviewed-by: Keith Packard <keithp at keithp.com>

(starting to think that merging notify_msc and present_pixmap in the
same function was a bad idea...)

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140930/ea6494d5/attachment.sig>


More information about the xorg-devel mailing list