[PATCH libX11] xcb_io: Fix Xlib 32-bit request number issues

Jan Smout smout.jan at gmail.com
Mon Sep 29 05:23:44 PDT 2014


I also spent some time trying to assess all possible cases (with very
limited knowledge on xlib internals), and I'm pretty sure Jonas has
dedicated even more time than the both of us did, but that's not the issue
here.

I agree the patch is hard, and maybe a more satisfactory solution could be
imagined by redesigning the 32-bit sequence numbers so that it aligns
better with xcb, but at some point a decision needs to be taken. In that
sense it *is* probably better to push the patch than to leave the current
situation as is where the application program just simply crashes...



On 27 September 2014 05:23, Keith Packard <keithp at keithp.com> wrote:

> Matt Turner <mattst88 at gmail.com> writes:
>
> > On Fri, Sep 26, 2014 at 3:40 AM, Jan Smout <smout.jan at gmail.com> wrote:
> >> Keith Packard doesn't seem very responsive (as in 'completely ignoring
> the
> >> subject')
> >
> > Perhaps you should try Ccing him? (now Cc'd)
>
> The problem is that reviewing this patch is *really hard*. The last
> time, I think I spent a solid couple of days thinking about this and
> making sure I'd caught all of the cases. I'm still not sure it's right,
> but I guess it's probably better than what we have?
>
> --
> keith.packard at intel.com
>



-- 
Life is complex, it has a real part and an imaginary part.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140929/18653970/attachment.html>


More information about the xorg-devel mailing list