[PATCH 11/19] xfree86: Remove spurious xf86ConfigError

Eric Anholt eric at anholt.net
Thu Sep 25 15:41:13 PDT 2014


Adam Jackson <ajax at redhat.com> writes:
> -/*
> - * xf86ConfigError --
> - *      Print a READABLE ErrorMessage!!!  All information that is 
> - *      available is printed.
> - */
> -static void
> -_X_ATTRIBUTE_PRINTF(1, 2)
> -xf86ConfigError(const char *msg, ...)
> -{
> -    va_list ap;
> -
> -    ErrorF("\nConfig Error:\n");
> -    va_start(ap, msg);
> -    VErrorF(msg, ap);
> -    va_end(ap);
> -    ErrorF("\n");
> -    return;
> -}

Yeah, doesn't seem useful, really.

(also, the "return;" as the last statement is just the best)

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140925/ec5ae500/attachment.sig>


More information about the xorg-devel mailing list