[PATCH driver/intel] In sna_pixmap_alloc_gpu() process user selected tiling thru kgem_choose_tiling()

Chris Wilson chris at chris-wilson.co.uk
Wed Sep 24 00:08:46 PDT 2014


On Wed, Sep 24, 2014 at 08:18:32AM +0200, Egbert Eich wrote:
> From: Egbert Eich <eich at suse.de>
> 
> In sna_pixmap_alloc_gpu() a different than the default tiling may be picked
> by a usage hint. Before passing the tiling to kgem_create_2d() fix it up
> by calling kgem_choose_tiling(). This avoids kgem_surface_size() not being able
> to find a surface size for the tiling value.
> 
> Signed-off-by: Egbert Eich <eich at freedesktop.org>

Tweaked the commit log and pushed:

commit dbe6d105a60ff28419b549d439bbb29f50b28f08
Author: Egbert Eich <eich at suse.de>
Date:   Wed Sep 24 08:18:32 2014 +0200

    sna: Validate framebuffer tiling before creation
    
    In sna_pixmap_alloc_gpu() a different than the default tiling may be picked
    by a usage hint. Before passing the tiling to kgem_create_2d() fix it up
    by calling kgem_choose_tiling(). This avoids kgem_surface_size() not being a
    to find a surface size for the tiling value.
    
    Fixes regression from
    
    commit a10781b70f222f3997928fa979f6292617f79316 [2.99.913]
    Author: Chris Wilson <chris at chris-wilson.co.uk>
    Date:   Tue Jul 1 15:11:07 2014 +0100
    
        sna: Enforce LinearFramebuffer option
    
    Signed-off-by: Egbert Eich <eich at freedesktop.org>

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the xorg-devel mailing list