[PATCH 2/2] Use unique display name for each xi2 test program

Peter Hutterer peter.hutterer at who-t.net
Mon Sep 22 14:50:45 PDT 2014


On Mon, Sep 22, 2014 at 02:02:26PM -0700, Keith Packard wrote:
> Peter Hutterer <peter.hutterer at who-t.net> writes:
> 
> > On Sun, Sep 21, 2014 at 09:49:06AM -0700, Alan Coopersmith wrote:
> >> make -j 8 check was sporadically failing in different xi2 tests.
> >> After adding the asserts in the previous commit to catch xkb failure
> >> it became easier to catch the failures and see that multiple tests
> >> were running at once trying to write to /tmp/server-(null).xkm and
> >> then delete it, and interfering with each other.
> >> 
> >> Putting a unique string into the display variable let them each write
> >> to their own file and not interfere with others.
> >> 
> >> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> >> ---
> >> 
> >> I've only tested on Solaris with getprogname(), not on Linux, where
> >> program_invocation_name would be used instead.  If neither is found
> >> we should either use something like mkstemp() or disable running the
> >> tests in parallel, but I've not bothered to go that far, since this
> >> covers enough platforms for me.
> >
> > Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
> > for both
> 
> Are you going to send a pull with this? Or shall I just merge?

just merge it please, thanks.

Cheers,
   Peter




More information about the xorg-devel mailing list