[PATCH xinit 0/1] startx: Pass "-nolisten tcp" by default

[Hans de Goede]

Hi,

On 09/12/2014 02:11 PM, Laurent Bigonville wrote:
> Le Fri, 12 Sep 2014 09:25:17 +0200,
> Hans de Goede <hdegoede at redhat.com> a écrit :
> 
>> Hi All,
> 
> Hello,
> 
>> After doing the 1.3.4 release yesterday, I've started working on
>> updating the Fedora packages to 1.3.4. While looking at our open bug
>> list against xinit, I found one bug which is not yet resolved in
>> 1.3.4 .
>>
>> This patch fixes this, I realize that this is a behavior change, and
>> as such may be a bit controversial, but I really believe that in this
>> day and age "-nolisten tcp" by default is the right thing to do.
> 
> On Debian we have the "-nolisten tcp" option set in the system-wide
> xserverrc file since 2006 at least.

Interesting, note though that startx will ignore xserverrc as soon as
any server options, including a display, are passed, so a not untypical
usage of:

startx -- :1

Will "circumvent" this.

> But isn't your patch preventing the user or local admin to explicitly
> ask to listen on tcp in xserverrc or .xserverrc ?

Which is why the actual commit message of the patch contains:

"Pass "-nolisten tcp" by default, and add a special -listen server option
 which can be used to disable this new default behavior."

As well as actually doing so, and documenting this in the man page :)

Regards,

Hans