[PATCH] Make list tests actually test lists

[Keith Packard]

Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> Coverity scan detected that asserts were setting values, not checking them:
>
> CID 53252: Side effect in assertion (ASSERT_SIDE_EFFECT)
>   assignment_where_comparison_intended: Assignment item->b = i * 2
>   has a side effect. This code will work differently in a non-debug build.
>   Did you intend to use a comparison ("==") instead?
>
> CID 53259: Side effect in assertion (ASSERT_SIDE_EFFECT)
>   assignment_where_comparison_intended: Assignment item->a = i
>   has a side effect. This code will work differently in a non-debug build.
>   Did you intend to use a comparison ("==") instead?
>
> CID 53260: Side effect in assertion (ASSERT_SIDE_EFFECT)
>   assignment_where_comparison_intended: Assignment item->a = i
>   has a side effect. This code will work differently in a non-debug build.
>   Did you intend to use a comparison ("==") instead?
>
> CID 53261: Side effect in assertion (ASSERT_SIDE_EFFECT)
>   assignment_where_comparison_intended: Assignment item->b = i * 2
>   has a side effect. This code will work differently in a non-debug build.
>   Did you intend to use a comparison ("==") instead?
>
> Fixing those to be == caused test_nt_list_insert to start failing as
> part assumed append order, part assumed insert order, so it had to be
> fixed to use consistent ordering.
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Merged (with review):
   d0da0e9..8f8dcfe  master -> master

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140911/0ec51563/attachment.sig>